feat: allow creating wallets with specified directory#140
Merged
ChrisSon15 merged 2 commits intobisq-network:mainfrom Mar 31, 2026
Merged
feat: allow creating wallets with specified directory#140ChrisSon15 merged 2 commits intobisq-network:mainfrom
ChrisSon15 merged 2 commits intobisq-network:mainfrom
Conversation
sdmg15
force-pushed
the
feat/allow-wallet-dir
branch
2 times, most recently
from
3345c1d to
4550c75
Compare
stejbac
reviewed
Mar 26, 2026
stejbac
reviewed
Mar 26, 2026
sdmg15
force-pushed
the
feat/allow-wallet-dir
branch
from
4550c75 to
4ae5cab
Compare
stejbac
reviewed
Mar 26, 2026
stejbac
reviewed
Mar 26, 2026
sdmg15
force-pushed
the
feat/allow-wallet-dir
branch
from
4ae5cab to
59a72fc
Compare
ChrisSon15
reviewed
Mar 26, 2026
ChrisSon15
requested changes
Mar 30, 2026
Collaborator
ChrisSon15
left a comment
ChrisSon15
left a comment
There was a problem hiding this comment.
We should make the path where the DB is put mandatory, as it should be for the production code. Test code should just pass in some tempdir-path.
sdmg15
force-pushed
the
feat/allow-wallet-dir
branch
from
522bff4 to
edf58ca
Compare
sdmg15
force-pushed
the
feat/allow-wallet-dir
branch
from
edf58ca to
aa5c756
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new function
new_with_dirwhich allows specifying the directory where the wallet will be created.I'm wondering if this should go to public API or keep it strictly callable under
tests.